Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use double splat for Ruby >= 3.0 #2915

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Use double splat for Ruby >= 3.0 #2915

wants to merge 2 commits into from

Conversation

patrickarnett
Copy link

@patrickarnett patrickarnett commented Oct 17, 2024 •
edited
Loading

Overview

Kafka::Consumer#each_message takes keyword arguments. In Ruby >= 3.0, prepending it with a method that takes only positional arguments causes an ArgumentError when calling super.

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fallwith fallwith Awaiting requested review from fallwith fallwith is a code owner

@hannahramadan hannahramadan Awaiting requested review from hannahramadan hannahramadan is a code owner

@kaylareopelle kaylareopelle Awaiting requested review from kaylareopelle kaylareopelle is a code owner

@tannalynn tannalynn Awaiting requested review from tannalynn tannalynn is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community To tag external issues and PRs submitted by the community
Projects
Ruby Engineering Board
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickarnett @CLAassistant